Re: [PATCH v4 2/2] pwm: mtk_disp: keep the trigger register after pwm setting.

[Thierry Reding]

On Tue, Dec 17, 2019 at 12:02:37PM +0800, Jitao Shi wrote:
> Move the trigger after pwm setting to avoid the pwm wrong signal
> output.
> 
> Remove the regist enable trigger setting in probe.
> Move the trigger to end of mtk_disp_pwm_config().
> 
> Signed-off-by: Jitao Shi <jitao.shi@xxxxxxxxxxxx>
> ---
>  drivers/pwm/pwm-mtk-disp.c | 20 +++++++-------------
>  1 file changed, 7 insertions(+), 13 deletions(-)

Same as for patch 1/2, please make the commit message more useful. Don't
say what you do (because the patch already shows that), but instead say
why you do it, what the specific problems are that you're fixing, etc.

Thierry

Attachment: signature.asc
Description: PGP signature