Re: [PATCH] pwm: remove set but not set variable 'pwm'

From: yukuai (C)
Date: Mon Jan 20 2020 - 06:40:52 EST


On 2020/1/20 15:34, Uwe Kleine-KÃnig wrote:
Fixes: e926b12c611c ("pwm: Clear chip_data in pwm_put()")

Thank you for your advise! I'll add 'Fixes' in a V2 patch.

Did you check that dropping the locking is save? (I didn't)

I'd assume that no harm is introduced, but mentioning that in the commit
log would be good.

I think dropping the lock is safe since there is nothing to be done
inside the lock. However, I didn't run a full test. By the way, I'll
mentioning it in a V2 patch.

Thanks!
Yu Kuai