Re: [PATCH v3 1/8] scsi: ufs: Fix ufshcd_probe_hba() reture value in case ufshcd_scsi_add_wlus() fails

[Alim Akhtar]

Hi Bean

On Sun, Jan 19, 2020 at 7:00 AM Alim Akhtar <alim.akhtar@xxxxxxxxx> wrote:
>
> Hi Bean
>
> On Sun, Jan 19, 2020 at 5:44 AM Bean Huo <huobean@xxxxxxxxx> wrote:
> >
> > From: Bean Huo <beanhuo@xxxxxxxxxx>
> >
> > A non-zero error value likely being returned by ufshcd_scsi_add_wlus()
> > in case of failure of adding the WLs, but ufshcd_probe_hba() doesn't
> > use this value, and doesn't report this failure to upper caller.
> > This patch is to fix this issue.
> >
> > Fixes: 2a8fa600445c ("ufs: manually add well known logical units")
> > Reviewed-by: Asutosh Das <asutoshd@xxxxxxxxxxxxxx>
> > Signed-off-by: Bean Huo <beanhuo@xxxxxxxxxx>
> > ---
> Signed-off-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
>
Sorry for noise, its not signed-off, please have my

Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

> >  drivers/scsi/ufs/ufshcd.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> > index bea036ab189a..9a9085a7bcc5 100644
> > --- a/drivers/scsi/ufs/ufshcd.c
> > +++ b/drivers/scsi/ufs/ufshcd.c
> > @@ -7032,7 +7032,8 @@ static int ufshcd_probe_hba(struct ufs_hba *hba)
> >                         ufshcd_init_icc_levels(hba);
> >
> >                 /* Add required well known logical units to scsi mid layer */
> > -               if (ufshcd_scsi_add_wlus(hba))
> > +               ret = ufshcd_scsi_add_wlus(hba);
> > +               if (ret)
> >                         goto out;
> >
> >                 /* Initialize devfreq after UFS device is detected */
> > --
> > 2.17.1
> >
>
>
> --
> Regards,
> Alim



-- 
Regards,
Alim