Re: [PATCH v2] io_uring: optimise sqe-to-req flags translation

[Pavel Begunkov]

On 18/01/2020 19:34, Jens Axboe wrote:
>> +enum {
>> +	/* correspond one-to-one to IOSQE_IO_* flags*/
>> +	REQ_F_FIXED_FILE	= BIT(REQ_F_FIXED_FILE_BIT),	/* ctx owns file */
> 
> I'd put the comment on top of the line instead, these lines are way too
> long.

I find it less readable, but let's see

> 
> Let's please not use BIT() for the user visible part, though. And I'd
> leave these as defines, sometimes apps do things ala:
> 
> #ifndef IOSQE_IO_LINK
> #define IOSQE_IO_LINK ...
> #endif
> 
> to make it easier to co-exist with old and new headers.
>Yeah, good point!

-- 
Pavel Begunkov

Attachment: signature.asc
Description: OpenPGP digital signature