Re: [PATCH v2] drivers: nvme: target: core: Pass lockdep expression to RCU lists

[kbuild test robot]

Hi Amol,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on hch-configfs/for-next]
[also build test ERROR on linux/master linus/master v5.5-rc6 next-20200117]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Amol-Grover/drivers-nvme-target-core-Pass-lockdep-expression-to-RCU-lists/20200111-084508
base:   git://git.infradead.org/users/hch/configfs.git for-next
config: i386-randconfig-e001-20200118 (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   In file included from include/linux/rbtree.h:22:0,
                    from include/linux/mm_types.h:10,
                    from include/linux/mmzone.h:21,
                    from include/linux/gfp.h:6,
                    from include/linux/umh.h:4,
                    from include/linux/kmod.h:9,
                    from include/linux/module.h:13,
                    from drivers/nvme/target/core.c:7:
   drivers/nvme/target/core.c: In function 'nvmet_setup_p2p_ns_map':
>> drivers/nvme/target/core.c:1179:22: error: 'subsys' undeclared (first use in this function); did you mean 'to_subsys'?
        lockdep_is_held(&subsys->lock))
                         ^
   include/linux/rcupdate.h:263:52: note: in definition of macro 'RCU_LOCKDEP_WARN'
      if (debug_lockdep_rcu_enabled() && !__warned && (c)) { \
                                                       ^
   include/linux/rculist.h:371:7: note: in expansion of macro '__list_check_rcu'
     for (__list_check_rcu(dummy, ## cond, 0),   \
          ^~~~~~~~~~~~~~~~
   include/linux/rculist.h:371:34: note: in expansion of macro 'lockdep_is_held'
     for (__list_check_rcu(dummy, ## cond, 0),   \
                                     ^~~~
   drivers/nvme/target/core.c:1178:2: note: in expansion of macro 'list_for_each_entry_rcu'
     list_for_each_entry_rcu(ns, &ctrl->subsys->namespaces, dev_link,
     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/nvme/target/core.c:1179:22: note: each undeclared identifier is reported only once for each function it appears in
        lockdep_is_held(&subsys->lock))
                         ^
   include/linux/rcupdate.h:263:52: note: in definition of macro 'RCU_LOCKDEP_WARN'
      if (debug_lockdep_rcu_enabled() && !__warned && (c)) { \
                                                       ^
   include/linux/rculist.h:371:7: note: in expansion of macro '__list_check_rcu'
     for (__list_check_rcu(dummy, ## cond, 0),   \
          ^~~~~~~~~~~~~~~~
   include/linux/rculist.h:371:34: note: in expansion of macro 'lockdep_is_held'
     for (__list_check_rcu(dummy, ## cond, 0),   \
                                     ^~~~
   drivers/nvme/target/core.c:1178:2: note: in expansion of macro 'list_for_each_entry_rcu'
     list_for_each_entry_rcu(ns, &ctrl->subsys->namespaces, dev_link,
     ^~~~~~~~~~~~~~~~~~~~~~~

vim +1179 drivers/nvme/target/core.c

  1164	
  1165	/*
  1166	 * Note: ctrl->subsys->lock should be held when calling this function
  1167	 */
  1168	static void nvmet_setup_p2p_ns_map(struct nvmet_ctrl *ctrl,
  1169			struct nvmet_req *req)
  1170	{
  1171		struct nvmet_ns *ns;
  1172	
  1173		if (!req->p2p_client)
  1174			return;
  1175	
  1176		ctrl->p2p_client = get_device(req->p2p_client);
  1177	
  1178		list_for_each_entry_rcu(ns, &ctrl->subsys->namespaces, dev_link,
> 1179					lockdep_is_held(&subsys->lock))
  1180			nvmet_p2pmem_ns_add_p2p(ctrl, ns);
  1181	}
  1182	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx Intel Corporation

Attachment: .config.gz
Description: application/gzip