Re: [PATCH v2] drivers: soc: ti: knav_qmss_queue: Pass lockdep expression to RCU lists

From: Olof Johansson
Date: Fri Jan 17 2020 - 14:26:52 EST


On Fri, Jan 17, 2020 at 10:24:04AM -0800, santosh.shilimkar@xxxxxxxxxx wrote:
> On 1/17/20 5:30 AM, Amol Grover wrote:
> > inst->handles is traversed using list_for_each_entry_rcu
> > outside an RCU read-side critical section but under the protection
> > of knav_dev_lock.
> >
> > Hence, add corresponding lockdep expression to silence false-positive
> > lockdep warnings, and harden RCU lists.
> >
> > Add macro for the corresponding lockdep expression.
> >
> > Signed-off-by: Amol Grover <frextrite@xxxxxxxxx>
> > ---
> > v2:
> > - Remove rcu_read_lock_held() from lockdep expression since it is
> > implicitly checked for.
> >
> Looks fine to me.
>
> Hi Olof, Arnd,
> Can you please pick this one and apply to your driver-soc branch ?
> I already sent out pull request and hence the request.

Hi,

Can you please email the whole patch with sign-off to
soc@xxxxxxxxxx? Otherwise it won't end up in patchwork, which is how we track
patches and pull requests these days.


Thanks,

-Olof