Re: [PATCH -next v5] mm/hotplug: silence a lockdep splat with printk()

[Qian Cai]

> On Jan 17, 2020, at 11:27 AM, David Hildenbrand <david@xxxxxxxxxx> wrote:
> 
> the "int" should go onto the next line as well
> [...]

Yes.

> apart from that looks good to me. I hope we won't have a whac-a-mole
> with printk() (including WARN_ON() etc?) under the zone lock. This all
> screams for a better fix.

WARN_ON() is normally not a concern. Once it happens here, we will figure out the reason why it happens in the first place and shut it off there instead.