Re: [PATCH v10 00/13] Support ROHM BD71828 PMIC

From: Lee Jones
Date: Fri Jan 17 2020 - 08:44:18 EST


On Fri, 17 Jan 2020, Vaittinen, Matti wrote:

>
> On Fri, 2020-01-17 at 10:30 +0000, Lee Jones wrote:
> > On Fri, 17 Jan 2020, Matti Vaittinen wrote:
> >
> > > Patch series introducing support for ROHM BD71828 PMIC
> > >
> > > ROHM BD71828 is a power management IC containing 7 bucks and 7
> > > LDOs. All
> > > regulators can be controlled individually via I2C. Bucks 1,2,6 and
> > > 7 can also be assigned to a "regulator group" controlled by run-
> > > levels.
> > > Eg. Run level specific voltages and enable/disable statuses for
> > > each of
> > > these bucks can be set via register interface. The buck run-level
> > > group
> > > assignment (selection if buck is to be controlled individually or
> > > via
> > > run-levels) can be changed at run-time via I2C.
> > >
> > > This patch series brings only the basic support for controlling
> > > regulators individually via I2C.
> > >
> > > In addition to the bucks and LDOs there are:
> > >
> > > - The usual clk gate
> > > - 4 IO pins (mostly usable as GPO or tied to specific purpose)
> > > - power button support
> > > - RTC
> > > - two LEDs
> > > - battery charger
> > > - HALL sensor input
> > >
> > > This patch series adds support to regulators, clk, RTC, GPIOs and
> > > LEDs.
> > >
> > > Power-supply driver for charger is not included in this series.
> > >
> > > The series also adds LED DT-node lookup based on node name or given
> > > property name/value pair in LED core. It also adds generic default-
> > > state
> > > and default-trigger property handling to LED core. Follow-up
> > > patches
> > > simplifying few other LED drivers should follow.
> > >
> > > Changelog v10:
> > > - Split RTC patch to a BD70528 fix (which hopefully goes to 5.4)
> > > and to
> > > BD71828 support
> >
> > Still missing LED Acks.
> >
>
> Yep. I know. I haven't heard from Pavel recently and the patch 12
> definitely requires his ack. Can you take the other patches in and
> leave 12 and 13 out for now? I can continue work on LEDs with Pavel but
> I would really like to have the regulators working and BD70528 RTC
> fixed in next release...

Sure. Give me a few days though.

--
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog