RE: [EXT] Re: [PATCH v2 2/9] scsi: ufs: Delete struct ufs_dev_desc

[Bean Huo (beanhuo)]

Hi, Bart

> On 2020-01-16 13:59, Bean Huo wrote:
> >  struct ufs_dev_fix {
> > -	struct ufs_dev_desc card;
> > +	u16 wmanufacturerid;
> > +	u8 *model;
> >  	unsigned int quirk;
> >  };
> >
> > -#define END_FIX { { 0 }, 0 }
> > +#define END_FIX { 0 }
> 
> A minor comment: please use { } instead of { 0 }.
> 
Will be changed in the next version.

> >  /* add specific device quirk */
> >  #define UFS_FIX(_vendor, _model, _quirk) { \
> > -	.card.wmanufacturerid = (_vendor),\
> > -	.card.model = (_model),		   \
> > +	.wmanufacturerid = (_vendor),\
> > +	.model = (_model),		   \
> >  	.quirk = (_quirk),		   \
> >  }
> 
> Is this macro useful? Does it improve readability of the code? If not, how about
> removing it (maybe later)?
> 
Before no better solution,  I think now we just keep it. 
> Anyway:
> 
> Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>
Thanks for reviewing.

//Bean