RE: [PATCH v10 11/14] exfat: add Kconfig and Makefile

From: Namjae Jeon
Date: Thu Jan 16 2020 - 23:22:34 EST


> > +config EXFAT_DEFAULT_IOCHARSET
> > + string "Default iocharset for exFAT"
> > + default "utf8"
> > + depends on EXFAT_FS
> > + help
> > + Set this to the default input/output character set you'd
> > + like exFAT to use. It should probably match the character set
> > + that most of your exFAT filesystems use, and can be overridden
> > + with the "iocharset" mount option for exFAT filesystems.
>
> Hello! This description is incorrect. iocharset option specify what
> character set is expected by VFS layer and not character set used by exFAT
> filesystem. exFAT filesystem always uses UTF-16 as this is the only
> allowed by exFAT specification.
Hi Pali,

Could you please review updated description ?

diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig
index 9eeaa6d06..f2b0cf2c1 100644
--- a/fs/exfat/Kconfig
+++ b/fs/exfat/Kconfig
@@ -15,7 +15,7 @@ config EXFAT_DEFAULT_IOCHARSET
default "utf8"
depends on EXFAT_FS
help
- Set this to the default input/output character set you'd
- like exFAT to use. It should probably match the character set
- that most of your exFAT filesystems use, and can be overridden
- with the "iocharset" mount option for exFAT filesystems.
+ Set this to the default input/output character set to use for
+ converting between the encoding is used for user visible filename and
+ UTF-16 character that exfat filesystem use. and can be overridden with
+ the "iocharset" mount option for exFAT filesystems.