Re: [PATCH net-next RFC 3/3] net/mlx5: Add FW upgrade reset support

From: Jakub Kicinski
Date: Thu Jan 16 2020 - 20:26:37 EST


On Thu, 16 Jan 2020 14:52:35 +0000, Moshe Shemesh wrote:
> > If multiple devices under one bridge are a real concern (or otherwise
> > interdependencies) would it make sense to mark the devices as "reload
> > pending" and perform the reloads once all devices in the group has this
> > mark set?
>
> All mlx5 current devices support PCI - Express only.
>
> PCI-Express device should have its own PCI-Express bridge, it is 1x1
> connection.
>
> So the check here is just to verify, all functions found under the
> bridge are expected to be the same device functions (PFs and VFs).

Ah, good, I couldn't confirm that PCIe fact with google fast enough :)
The check sounds good then, with perhaps a small suggestion to add
a helper in PCIe core if it's already done by two drivers? Can be as
a follow up..