Re: [PATCH bpf-next v3 09/11] selftests: Remove tools/lib/bpf from include path

From: Andrii Nakryiko
Date: Thu Jan 16 2020 - 18:06:02 EST


On Thu, Jan 16, 2020 at 2:41 PM Andrii Nakryiko
<andrii.nakryiko@xxxxxxxxx> wrote:
>
> On Thu, Jan 16, 2020 at 5:28 AM Toke HÃiland-JÃrgensen <toke@xxxxxxxxxx> wrote:
> >
> > From: Toke HÃiland-JÃrgensen <toke@xxxxxxxxxx>
> >
> > To make sure no new files are introduced that doesn't include the bpf/
> > prefix in its #include, remove tools/lib/bpf from the include path
> > entirely.
> >
> > Instead, we introduce a new header files directory under the scratch tools/
> > dir, and add a rule to run the 'install_headers' rule from libbpf to have a
> > full set of consistent libbpf headers in $(OUTPUT)/tools/include/bpf, and
> > then use $(OUTPUT)/tools/include as the include path for selftests.
> >
> > For consistency we also make sure we put all the scratch build files from
> > other bpftool and libbpf into tools/build/, so everything stays within
> > selftests/.
> >
> > Signed-off-by: Toke HÃiland-JÃrgensen <toke@xxxxxxxxxx>
> > ---

BTW, this change also now forces full rebuild regardless if anything
changed or not :(

[...]