Re: [alsa-devel] [PATCH] soundwire: cadence: fix kernel-doc parameter descriptions

From: Pierre-Louis Bossart
Date: Thu Jan 16 2020 - 10:57:17 EST




On 1/16/20 6:09 AM, Vinod Koul wrote:
On 16-01-20, 17:35, Vinod Koul wrote:
On 14-01-20, 17:31, Pierre-Louis Bossart wrote:
Fix previous update, bad git merge likely. oops.

Applied, thanks

Btw I still have these warns on my next with W=1

drivers/soundwire/intel_init.c:193:7: warning: no previous prototype for âsdw_intel_initâ [-Wmissing-prototypes]
void *sdw_intel_init(acpi_handle *parent_handle, struct sdw_intel_res *res)
^~~~~~~~~~~~~~
drivers/soundwire/cadence_master.c:1022: warning: Function parameter or member 'clock_stop_exit' not described in 'sdw_cdns_init'
LD [M] drivers/soundwire/soundwire-cadence.o
drivers/soundwire/intel_init.c:214: warning: Function parameter or member 'ctx' not described in 'sdw_intel_exit'
drivers/soundwire/intel_init.c:214: warning: Excess function parameter 'arg' description in 'sdw_intel_exit'

All of this is replaced by new code already submitted for review. try our SOF upstream/soundwire branch and you'll see.