Re: [PATCH net-next v3] openvswitch: add TTL decrement action

From: Nicolas Dichtel
Date: Thu Jan 16 2020 - 08:39:01 EST


Le 16/01/2020 Ã 08:21, Pravin Shelar a ÃcritÂ:
> On Wed, Jan 15, 2020 at 8:40 AM Matteo Croce <mcroce@xxxxxxxxxx> wrote:
[snip]
>> @@ -1050,4 +1051,5 @@ struct ovs_zone_limit {
>> __u32 count;
>> };
>>
>> +#define OVS_DEC_TTL_ATTR_EXEC 0
>
> I am not sure if we need this, But if you want the nested attribute
> then lets define enum with this single attribute and have actions as
> part of its data. This would be optional argument, so userspace can
> skip it, and in that case datapath can drop the packet.
And note that 0 is a reserved value and should not be used. Look at other
attributes.

Regards,
Nicolas