Re: [PATCH v2 -next] drivers/net: netdevsim depends on INET

From: Jakub Kicinski
Date: Thu Jan 16 2020 - 08:31:39 EST


On Thu, 16 Jan 2020 21:14:04 +0800, Hongbo Yao wrote:
> If CONFIG_INET is not set and CONFIG_NETDEVSIM=y.
> Building drivers/net/netdevsim/fib.o will get the following error:
>
> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_hw_flags_set':
> fib.c:(.text+0x12b): undefined reference to `fib_alias_hw_flags_set'
> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_destroy':
> fib.c:(.text+0xb11): undefined reference to `free_fib_info'
>
> Correct the Kconfig for netdevsim.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Fixes: 48bb9eb47b270("netdevsim: fib: Add dummy implementation for FIB offload")

Looks better :) Still missing a space between the hash and the bracket,
but:

Acked-by: Jakub Kicinski <kuba@xxxxxxxxxx>

While at it - does mlxsw have the same problem by any chance?