RE: [PATCH v2] x86/mce/therm_throt: Fix the access of uninitialized therm_work

From: Liu, Chuansheng
Date: Mon Jan 13 2020 - 21:19:29 EST




> -----Original Message-----
> From: Borislav Petkov <bp@xxxxxxxxx>
> Sent: Monday, January 13, 2020 5:05 PM
> To: Luck, Tony <tony.luck@xxxxxxxxx>
> Cc: Liu, Chuansheng <chuansheng.liu@xxxxxxxxx>; linux-
> kernel@xxxxxxxxxxxxxxx; tglx@xxxxxxxxxxxxx; mingo@xxxxxxxxxx;
> hpa@xxxxxxxxx
> Subject: Re: [PATCH v2] x86/mce/therm_throt: Fix the access of uninitialized
> therm_work
>
> On Fri, Jan 10, 2020 at 10:29:29AM -0800, Luck, Tony wrote:
> > On Tue, Jan 07, 2020 at 12:41:16AM +0000, Chuansheng Liu wrote:
> > > In my ICL platform, it can be reproduced in several times
> > > of reboot stress. With this fix, the system keeps alive
> > > for more than 200 times of reboot stress.
> > >
> > > V2: Boris shares a good suggestion that we can moving the
> > > interrupt unmasking at the end of therm_work initialization.
> > >
> > > Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx>
> >
> > Looks good to me:
> >
> > Acked-by: Tony Luck <tony.luck@xxxxxxxxx>
>
> Thx.
>
> This "ICL platform" - whatever that is - is this shipping already so
I just can say ICL(icelake) is shipped platform, I reproduced this issue
in one laptop.