Re: [PATCH] xfs: Fix xfs_dir2_sf_entry_t size check

From: Christoph Hellwig
Date: Mon Jan 13 2020 - 08:58:08 EST


On Mon, Jan 13, 2020 at 02:55:15PM +0100, Arnd Bergmann wrote:
> With ARM OABI (which you get when EABI is disabled), structures are padded
> to multiples of 32 bits. See commits 8353a649f577 ("xfs: kill
> xfs_dir2_sf_off_t")
> and aa2dd0ad4d6d ("xfs: remove __arch_pack"). Those could be partially
> reverted to fix it again, but it doesn't seem worth it as there is
> probably nobody
> running XFS on OABI machines (actually with the build failure we can
> be fairly sure there isn't ;-).

Or just try adding a __packed to the xfs_dir2_sf_entry definition?