Re: [PATCH v2] iio: imu/mpu6050: support dual-edge IRQ

From: Michał Mirosław
Date: Sat Jan 11 2020 - 10:07:45 EST


On Sat, Jan 11, 2020 at 12:10:47PM +0000, Jonathan Cameron wrote:
> On Mon, 06 Jan 2020 12:17:54 +0100
> Michał Mirosław <mirq-linux@xxxxxxxxxxxx> wrote:
>
> > Make mpu6050 usable on platforms which provide only any-edge interrupts.
> > This also covers shared interrupt case.
>
> So this had me confused for a bit because I assumed we were trying to make
> a level interrupt providing device work with edge interrupts. Seems
> device supports a pulsed mode and the driver supports this.
>
> Why do we want to detect on both edges? Do you have a crazy board
> with this shared and some devices using the rising edge and some the falling one?
>
> For shared case it should return that it did not handle the interrupt
> to allow spurious interrupt detection to work...

Hmm. The shared interrupt is a red herring. I'll remove the sentence
from commitmsg as it looks like the driver needs a few more fixups
to be able to share the interrupt line.

The patch is required on platforms that support only dual-edge
interrupts, like eg. AT91SAM9G45-based one I have.

Best Regards,
Michał Mirosław