Re: [RESEND PATCH v10 03/10] mmu: spp: Add SPP Table setup functions

From: Sean Christopherson
Date: Fri Jan 10 2020 - 12:40:29 EST


On Thu, Jan 02, 2020 at 02:13:12PM +0800, Yang Weijiang wrote:
> SPPT is a 4-level paging structure similar to EPT, when SPP is
> armed for target physical page, bit 61 of the corresponding
> EPT entry is flaged, then SPPT is traversed with the gfn,
> the leaf entry of SPPT contains the access bitmap of subpages
> inside the target 4KB physical page, one bit per 128-byte subpage.
>
> Co-developed-by: He Chen <he.chen@xxxxxxxxxxxxxxx>
> Signed-off-by: He Chen <he.chen@xxxxxxxxxxxxxxx>
> Co-developed-by: Zhang Yi <yi.z.zhang@xxxxxxxxxxxxxxx>
> Signed-off-by: Zhang Yi <yi.z.zhang@xxxxxxxxxxxxxxx>
> Signed-off-by: Yang Weijiang <weijiang.yang@xxxxxxxxx>
> ---
> arch/x86/include/asm/kvm_host.h | 5 +-
> arch/x86/kvm/mmu/spp.c | 228 ++++++++++++++++++++++++++++++++
> arch/x86/kvm/mmu/spp.h | 10 ++

This patch is completely untesteable. It adds spp.c but doesn't compile
it. Actually, everything up until patch 06 is untestable.