Re: [PATCH v2 22/36] platform/x86: intel_pmc_ipc: Drop ipc_data_readb()

From: Andy Shevchenko
Date: Wed Jan 08 2020 - 11:47:23 EST


On Wed, Jan 08, 2020 at 02:41:47PM +0300, Mika Westerberg wrote:
> This function is not used anywhere so drop it completely.
>

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

> Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> ---
> drivers/platform/x86/intel_pmc_ipc.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/platform/x86/intel_pmc_ipc.c b/drivers/platform/x86/intel_pmc_ipc.c
> index 677ed470e14e..83b106f66fa6 100644
> --- a/drivers/platform/x86/intel_pmc_ipc.c
> +++ b/drivers/platform/x86/intel_pmc_ipc.c
> @@ -184,11 +184,6 @@ static inline void ipc_data_writel(u32 data, u32 offset)
> writel(data, ipcdev.ipc_base + IPC_WRITE_BUFFER + offset);
> }
>
> -static inline u8 __maybe_unused ipc_data_readb(u32 offset)
> -{
> - return readb(ipcdev.ipc_base + IPC_READ_BUFFER + offset);
> -}
> -
> static inline u32 ipc_data_readl(u32 offset)
> {
> return readl(ipcdev.ipc_base + IPC_READ_BUFFER + offset);
> --
> 2.24.1
>

--
With Best Regards,
Andy Shevchenko