Re: [PATCH 5/8] net: bluetooth: remove unneeded MODULE_VERSION() usage
From: Greg KH
Date: Sun Jan 05 2020 - 05:42:26 EST
On Sun, Jan 05, 2020 at 10:34:56AM +0100, Marcel Holtmann wrote:
> Hi Enrico,
>
> > Remove MODULE_VERSION(), as it isn't needed at all: the only version
> > making sense is the kernel version.
>
> I prefer to keep the MODULE_VERSION info since it provides this
> information via modinfo.
Sure, but it's really pointless :)
> Unless there is a kernel wide consent to remove MODULE_VERSION
> altogether, the Bluetooth subsystem is keeping it.
I've deleted them from lots of drivers/subsystems already as they do not
make any sense when you think about vendor kernels, stable kernels, and
upstream kernel versions.
thanks,
greg k-h