Re: [f2fs-dev] [RFC PATCH v5] f2fs: support data compression

[Chao Yu]

On 2019-12-16 19:32, Markus Elfring wrote:
> â
> > +++ b/fs/f2fs/compress.c
> > @@ -0,0 +1,1139 @@
> â
> > +bool f2fs_is_compressed_page(struct page *page)
> > +{
> > +	if (!PagePrivate(page))
> > +		return false;
> > +	if (!page_private(page))
> > +		return false;
> > +	if (IS_ATOMIC_WRITTEN_PAGE(page) || IS_DUMMY_WRITTEN_PAGE(page))
> > +		return false;
> â
>
> How do you think about to combine condition checks like the following?
>
> +	if (!PagePrivate(page) || !page_private(page) ||
> +	    IS_ATOMIC_WRITTEN_PAGE(page) || IS_DUMMY_WRITTEN_PAGE(page))
> +		return false;

That's f2fs coding style, I guess it will a little bit easiler to understand one 
single condition than understanding combined one.

Thanks,

> Would you like to apply similar transformations at other source code places?
>
> Regards,
> Markus
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel