Re: [PATCH AUTOSEL 5.4 277/350] tpm: Add a flag to indicate TPM power is managed by firmware

From: Jarkko Sakkinen
Date: Thu Dec 12 2019 - 19:17:40 EST


On Wed, Dec 11, 2019 at 10:05:52AM -0800, Guenter Roeck wrote:
> On Wed, Dec 11, 2019 at 9:57 AM Jarkko Sakkinen
> <jarkko.sakkinen@xxxxxxxxxxxxxxx> wrote:
> >
> > On Tue, Dec 10, 2019 at 01:32:15PM -0800, Guenter Roeck wrote:
> > > On Tue, Dec 10, 2019 at 1:12 PM Sasha Levin <sashal@xxxxxxxxxx> wrote:
> > > >
> > > > From: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> > > >
> > > > [ Upstream commit 2e2ee5a2db06c4b81315514b01d06fe5644342e9 ]
> > > >
> > > > On some platforms, the TPM power is managed by firmware and therefore we
> > > > don't need to stop the TPM on suspend when going to a light version of
> > > > suspend such as S0ix ("freeze" suspend state). Add a chip flag,
> > > > TPM_CHIP_FLAG_FIRMWARE_POWER_MANAGED, to indicate this so that certain
> > > > platforms can probe for the usage of this light suspend and avoid
> > > > touching the TPM state across suspend/resume.
> > > >
> > >
> > > Are the patches needed to support CR50 (which need this patch) going
> > > to be applied to v5.4.y as well ? If not, what is the purpose of
> > > applying this patch to v5.4.y ?
> > >
> > > Thanks,
> > > Guenter
> >
> > Thanks Guenter. I think not.
> >
> Thought so. In that case this patch should be dropped.
>
> Guenter

I fully agree with you.

/Jarkko