Re: [PATCH v2 11/23] staging: qlge: Fix CHECK: braces {} should be used on all arms of this statement

From: Dan Carpenter
Date: Thu Dec 12 2019 - 07:12:23 EST


On Wed, Dec 11, 2019 at 12:12:40PM -0600, Scott Schafer wrote:
> @@ -351,8 +352,9 @@ static int ql_aen_lost(struct ql_adapter *qdev, struct mbox_params *mbcp)
> mbcp->out_count = 6;
>
> status = ql_get_mb_sts(qdev, mbcp);
> - if (status)
> + if (status) {
> netif_err(qdev, drv, qdev->ndev, "Lost AEN broken!\n");
> + }
> else {

The close } should be on the same line as the else.

> int i;
>

regards,
dan carpenter