RE: [PATCH] nios2: Fix ioremap

[Tan, Ley Foon]

> -----Original Message-----
> From: Guenter Roeck <groeck7@xxxxxxxxx> On Behalf Of Guenter Roeck
> Sent: Thursday, December 5, 2019 10:41 AM
> To: Ley Foon Tan <lftan@xxxxxxxxxx>
> Cc: nios2-dev@xxxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> Guenter Roeck <linux@xxxxxxxxxxxx>; Christoph Hellwig <hch@xxxxxx>
> Subject: [PATCH] nios2: Fix ioremap
> 
> Commit 5ace77e0b41a ("nios2: remove __ioremap") removed the following
> code, with the argument that cacheflag is always 0 and the expression would
> therefore always be false.
> 
>         if (IS_MAPPABLE_UNCACHEABLE(phys_addr) &&
>             IS_MAPPABLE_UNCACHEABLE(last_addr) &&
>             !(cacheflag & _PAGE_CACHED))
>                 return (void __iomem *)(CONFIG_NIOS2_IO_REGION_BASE +
> phys_addr);
> 
> This did not take the "!" in the expression into account. Result is that
> nios2 images no longer boot. Restoring the removed code fixes the problem.
> 
> Fixes: 5ace77e0b41a ("nios2: remove __ioremap")
> Cc: Christoph Hellwig <hch@xxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Will add to next rc. 
Thanks.

Acked-by: Ley Foon Tan <ley.foon.tan@xxxxxxxxx>