CONFIG_COMMON_CLK vs CONFIG_HAVE_CLK

From: Kuninori Morimoto
Date: Wed Dec 11 2019 - 21:09:26 EST



Hi

I noticed that there are some CONFIG_HAVE_CLK vs CONFIG_COMMON_CLK mismatch.
Because of it, I got compile error at clk_set_min_rate() on SH.
SH will have HAVE_CLK, but doesn't have COMMON_CLK.

> ARCH=sh make allyesconfig
> make
...
drivers/devfreq/tegra30-devfreq.o: In function `tegra_devfreq_target':
tegra30-devfreq.c:(.text+0x368): undefined reference to `clk_set_min_rate'

clk_set_min_rate() is under HAVE_CLK at clk.h

--- clk.h ---
=> #ifdef CONFIG_HAVE_CLK
...
int clk_set_min_rate(struct clk *clk, unsigned long rate);
...
#else /* !CONFIG_HAVE_CLK */
static inline int clk_set_min_rate(struct clk *clk, unsigned long rate)
...
-------------

It is implemented at clk.c.
But it will be compiled via COMMON_CLK

--- Makefile ---
...
=> obj-$(CONFIG_COMMON_CLK) += clk.o
...
----------------

Thank you for your help !!
Best regards
---
Kuninori Morimoto