RE: [RFC PATCH v1 2/4] mm: also set VMA in khugepaged range invalidation

From: Mircea CIRJALIU - MELIU
Date: Wed Dec 11 2019 - 11:16:27 EST


> On Wed, Dec 11, 2019 at 09:29:21AM +0000, Mircea CIRJALIU - MELIU wrote:
> > MMU notifier client may need the VMA for extra info.
> > This change is needed by the remote mapping feature that inspects anon
> > VMAs with huge mappings.
>
> The change itself is okay, but commit message should be better.
>
> Do we have any user of mmu notifiers in current kernel that affected by the
> missing vma here?

No. This patch is a small part of a series of commits for the remote mapping feature.
The kernel can do well without it.

>
> And subject starting with 'also' looks wrong to me.
>
> --
> Kirill A. Shutemov

Mircea