Re: [PATCH v5 13/16] rtc: bd70528 add BD71828 support

From: Alexandre Belloni
Date: Tue Dec 10 2019 - 08:24:14 EST


Hi,

On 18/11/2019 09:00:47+0200, Matti Vaittinen wrote:
> @@ -468,26 +596,35 @@ static int bd70528_probe(struct platform_device *pdev)
> * leave them enabled as irq-controller should disable irqs
> * from sub-registers when IRQ is disabled or freed.
> */
> - ret = regmap_update_bits(mfd->regmap,
> + if (enable_main_irq) {
> + ret = regmap_update_bits(mfd->regmap,
> BD70528_REG_INT_MAIN_MASK,
> BD70528_INT_RTC_MASK, 0);
> - if (ret) {
> - dev_err(&pdev->dev, "Failed to enable RTC interrupts\n");
> - return ret;
> + if (ret) {
> + dev_err(&pdev->dev, "Failed to enable RTC interrupts\n");
> + return ret;
> + }
> }
>
> return rtc_register_device(rtc);
> }

Missing blank line here.

> +static const struct platform_device_id bd718x7_rtc_id[] = {
> + { "bd70528-rtc", ROHM_CHIP_TYPE_BD70528 },
> + { "bd71828-rtc", ROHM_CHIP_TYPE_BD71828 },
> + { },
> +};
> +MODULE_DEVICE_TABLE(platform, bd718x7_rtc_id);
>

Else, Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com