Re: [PATCH] regulator: max77650: add of_match table

From: Bartosz Golaszewski
Date: Tue Dec 10 2019 - 07:51:51 EST


wt., 10 gru 2019 o 13:12 Mark Brown <broonie@xxxxxxxxxx> napisaÅ(a):
>
> On Tue, Dec 10, 2019 at 11:07:25AM +0100, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> >
> > We need the of_match table if we want to use the compatible string in
> > the pmic's child node and get the regulator driver loaded automatically.
>
> Why would we need to use a compatible string in a child node to load the
> regulator driver, surely we can just register a platform device in the
> MFD?

The device is registered all right from MFD code, but the module won't
be loaded automatically from user-space even with the right
MODULE_ALIAS() for sub-nodes unless we define the
MODULE_DEVICE_TABLE().

Besides: the DT bindings define the compatible for sub-nodes already.
We should probably conform to that.

Bart