Re: [PATCH] perf/smmuv3: Remove the leftover put_cpu() in error path

From: Robin Murphy
Date: Tue Dec 10 2019 - 06:04:40 EST


On 10/12/2019 10:46 am, Hanjun Guo wrote:
In smmu_pmu_probe(), there is put_cpu() in the error path,
which is wrong because we use raw_smp_processor_id() to
get the cpu ID, not get_cpu(), remove it.

Bah, somehow that slipped through the last round of review :)

Acked-by: Robin Murphy <robin.murphy@xxxxxxx>

Signed-off-by: Hanjun Guo <guohanjun@xxxxxxxxxx>
---
drivers/perf/arm_smmuv3_pmu.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/perf/arm_smmuv3_pmu.c b/drivers/perf/arm_smmuv3_pmu.c
index 773128f..fd1d46a 100644
--- a/drivers/perf/arm_smmuv3_pmu.c
+++ b/drivers/perf/arm_smmuv3_pmu.c
@@ -834,7 +834,6 @@ static int smmu_pmu_probe(struct platform_device *pdev)
out_unregister:
cpuhp_state_remove_instance_nocalls(cpuhp_state_num, &smmu_pmu->node);
out_cpuhp_err:
- put_cpu();
return err;
}