RE: [RFC PATCH] usb:gadget: Fixed issue with config_ep_by_speed function.

From: Jayshri Dajiram Pawar
Date: Tue Dec 10 2019 - 05:31:20 EST




> -----Original Message-----
> From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Tuesday, December 10, 2019 3:53 PM
> To: Jayshri Dajiram Pawar <jpawar@xxxxxxxxxxx>
> Cc: linux-usb@xxxxxxxxxxxxxxx; felipe.balbi@xxxxxxxxxxxxxxx;
> heikki.krogerus@xxxxxxxxxxxxxxx; rogerq@xxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; jbergsagel@xxxxxx; nsekhar@xxxxxx; nm@xxxxxx;
> peter.chen@xxxxxxx; Rahul Kumar <kurahul@xxxxxxxxxxx>; Pawel
> Laszczak <pawell@xxxxxxxxxxx>; Sanket Parmar <sparmar@xxxxxxxxxxx>
> Subject: Re: [RFC PATCH] usb:gadget: Fixed issue with config_ep_by_speed
> function.
>
> EXTERNAL MAIL
>
>
> On Mon, Dec 02, 2019 at 12:07:27PM +0100, Jayshri Pawar wrote:
> > /**
> > * config_ep_by_speed() - configures the given endpoint @@ -144,9
> > +146,11 @@ next_ep_desc(struct usb_descriptor_header **t)
> > */
> > int config_ep_by_speed(struct usb_gadget *g,
> > struct usb_function *f,
> > - struct usb_ep *_ep)
> > + struct usb_ep *_ep,
> > + unsigned alt)
>
> Why did you not document this new parameter? It does not make sense to
> me, what does it do, and how is it supposed to be used?
Hi Greg,
New parameter is documented and updated in patch v2.

Thanks,
Jayshri


>
> thanks,
>
> greg k-h