[PATCH 3.16 54/72] can: gs_usb: gs_can_open(): prevent memory leak

From: Ben Hutchings
Date: Sun Dec 08 2019 - 08:56:32 EST


3.16.79-rc1 review patch. If anyone has any objections, please let me know.

------------------

From: Navid Emamdoost <navid.emamdoost@xxxxxxxxx>

commit fb5be6a7b4863ecc44963bb80ca614584b6c7817 upstream.

In gs_can_open() if usb_submit_urb() fails the allocated urb should be
released.

Fixes: d08e973a77d1 ("can: gs_usb: Added support for the GS_USB CAN devices")
Signed-off-by: Navid Emamdoost <navid.emamdoost@xxxxxxxxx>
Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
---
drivers/net/can/usb/gs_usb.c | 1 +
1 file changed, 1 insertion(+)

--- a/drivers/net/can/usb/gs_usb.c
+++ b/drivers/net/can/usb/gs_usb.c
@@ -617,6 +617,7 @@ static int gs_can_open(struct net_device
rc);

usb_unanchor_urb(urb);
+ usb_free_urb(urb);
break;
}