Re: [PATCH] checkpatch: Look for Kconfig indentation errors

From: Joe Perches
Date: Thu Nov 28 2019 - 04:35:19 EST


On Thu, 2019-11-28 at 11:29 +0200, Jani Nikula wrote:
> On Thu, 28 Nov 2019, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> > Kconfig should be indented with one tab for first level and tab+2 spaces
> > for second level. There are many mixups of this so add a checkpatch
> > rule.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>
> I agree unifying the indentation is nice, and without something like
> this it'll start bitrotting before Krzysztof's done fixing them all... I
> think there's been quite a few fixes merged lately.
>
> I approve of the idea, but I'm clueless about the implementation.

I think that a grammar, or a least an array of words
that are supposed to start on a tab should be used here.