Re: [PATCH] {tty: serial, nand: onenand}: remove variable 'ufstat' set but not used

From: Greg KH
Date: Fri Nov 22 2019 - 06:39:04 EST


On Fri, Nov 22, 2019 at 07:33:47PM +0800, Chen Wandun wrote:
>
>
> On 2019/11/22 19:14, Greg KH wrote:
> > On Fri, Nov 22, 2019 at 07:12:39PM +0800, Chen Wandun wrote:
> > > Fixes gcc '-Wunused-but-set-variable' warning:
> > >
> > > drivers/tty/serial/samsung_tty.c: In function s3c24xx_serial_rx_chars_dma:
> > > drivers/tty/serial/samsung_tty.c:549:24: warning: variable ufstat set but not used [-Wunused-but-set-variable]
> > >
> > > Signed-off-by: Chen Wandun <chenwandun@xxxxxxxxxx>
> >
> > Your subject line is really odd, can you please fix that up and resend?
> I check the git log of drivers/tty/serial/samsung_tty.c,
> it seem like the subject line should be:
> {tty: serial, nand: onenand}: samsung: remove variable 'ufstat' set but not used
>
> Is that OK?

No. What does this patch have to do with nand?

That was from a previous patch that modified two drivers at once. You
are not touching the nand driver.

thanks,

greg k-h