RE: [PATCHv2 1/6] ASoC: da7213: Add da7212 DT compatible

[Adam Thomson]

On 20 November 2019 15:24, Sebastian Reichel wrote: 

> This adds a compatible for da7212. It's handled exactly the
> same way as DA7213 and follows the ACPI bindings.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/sound/da7213.txt | 4 ++--
>  sound/soc/codecs/da7213.c                          | 1 +
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/da7213.txt
> b/Documentation/devicetree/bindings/sound/da7213.txt
> index 58902802d56c..759bb04e0283 100644
> --- a/Documentation/devicetree/bindings/sound/da7213.txt
> +++ b/Documentation/devicetree/bindings/sound/da7213.txt
> @@ -1,9 +1,9 @@
> -Dialog Semiconductor DA7213 Audio Codec bindings
> +Dialog Semiconductor DA7212/DA7213 Audio Codec bindings
> 
>  ======
> 
>  Required properties:
> -- compatible : Should be "dlg,da7213"
> +- compatible : Should be "dlg,da7212" or "dlg,7213"

Typo? "dlg,da7213"

>  - reg: Specifies the I2C slave address
> 
>  Optional properties:
> diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c
> index 925a03996db4..aff306bb58df 100644
> --- a/sound/soc/codecs/da7213.c
> +++ b/sound/soc/codecs/da7213.c
> @@ -1571,6 +1571,7 @@ static int da7213_set_bias_level(struct
> snd_soc_component *component,
>  #if defined(CONFIG_OF)
>  /* DT */
>  static const struct of_device_id da7213_of_match[] = {
> +	{ .compatible = "dlg,da7212", },
>  	{ .compatible = "dlg,da7213", },
>  	{ }
>  };
> --
> 2.24.0