Re: [PATCH 2/3] reset: Fix {of,devm}_reset_control_array_get kerneldoc return types

From: Philipp Zabel
Date: Wed Nov 20 2019 - 09:43:52 EST


On Wed, 2019-11-20 at 15:26 +0100, Geert Uytterhoeven wrote:
> of_reset_control_array_get() and devm_reset_control_array_get() return
> struct reset_control pointers, not internal struct reset_control_array
> pointers, just like all other reset control API calls.
>
> Correct the kerneldoc to match the code.
>
> Fixes: 17c82e206d2a3cd8 ("reset: Add APIs to manage array of resets")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> drivers/reset/core.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> index 55245f485b3819da..4ea62aa00260f82c 100644
> --- a/drivers/reset/core.c
> +++ b/drivers/reset/core.c
> @@ -861,8 +861,7 @@ static int of_reset_control_get_count(struct device_node *node)
> * @acquired: only one reset control may be acquired for a given controller
> * and ID
> *
> - * Returns pointer to allocated reset_control_array on success or
> - * error on failure
> + * Returns pointer to allocated reset_control on success or error on failure
> */
> struct reset_control *
> of_reset_control_array_get(struct device_node *np, bool shared, bool optional,
> @@ -915,8 +914,7 @@ EXPORT_SYMBOL_GPL(of_reset_control_array_get);
> * that just have to be asserted or deasserted, without any
> * requirements on the order.
> *
> - * Returns pointer to allocated reset_control_array on success or
> - * error on failure
> + * Returns pointer to allocated reset_control on success or error on failure
> */
> struct reset_control *
> devm_reset_control_array_get(struct device *dev, bool shared, bool optional)

Thank you, applied to reset/fixes.

regards
Philipp