Re: [PATCH v2 1/2] perf util: Move block tui function to ui browsers

From: Arnaldo Carvalho de Melo
Date: Tue Nov 19 2019 - 17:37:41 EST


Em Tue, Nov 19, 2019 at 09:09:27PM +0100, Jiri Olsa escreveu:
> On Mon, Nov 18, 2019 at 10:08:48PM +0800, Jin Yao wrote:
> > It would be nice if we could jump to the assembler/source view
> > (like the normal perf report) from total cycles view.
> >
> > This patch moves the block_hists_tui_browse from block-info.c
> > to ui/browsers/hists.c in order to reuse some browser codes
> > (i.e do_annotate) for implementing new annotation view.
> >
> > v2:
> > ---
> > Fix the 'make NO_SLANG=1' error. (Change 'int block_hists_tui_browse()'
> > to 'static inline int block_hists_tui_browse()')
> >
> > Signed-off-by: Jin Yao <yao.jin@xxxxxxxxxxxxxxx>
>
> for both patches
>
> Acked-by: Olsa <jolsa@xxxxxxxxxx>

Thanks, tested and applied.

- Arnaldo