Re: [PATCH v3 0/7] x86/intel_pmc_core: Add Tiger Lake, Elkhart Lake

From: Andy Shevchenko
Date: Mon Nov 18 2019 - 05:50:39 EST


On Thu, Nov 14, 2019 at 7:02 PM Gayatri Kammela
<gayatri.kammela@xxxxxxxxx> wrote:
>
> Hi,
>
> Patch 1: Fix SoC naming inconsistency
> Patch 2: Cleans up termination lines
> Patch 3: Refactor driver for ease of adding new SoCs
> Patch 4: Add debugfs entry for PCH IPs only if platform supports
> Patch 5: Add Tiger Lake legacy support to pmc_core
> Patch 6: Add Elkhart Lake legacy support to pmc_core
> patch 7: Add Comet Lake legacy support to pmc_core
>
> All the information regarding the PCH IPs and names of IPs will be
> available in Intel's Platform Controller Hub (PCH) External Design
> Specification (EDS) document expected to be released in 2020 before
> product launch.

Thanks, though you forgot to fix all prefixes in the mails. We have
platform/x86: $DRIVER_NAME: ...

Also consider Mario's comment (I didn't hear back from you on it).

>
> Changes since v1:
> 1) Added a patch that fixes the naming inconsistency.
> 2) Fixed the prefix of all the patches.
>
> Changes since v2:
> 1) Add Comet Lake legacy support to pmc_core up on Dell's request
>
> Gayatri Kammela (7):
> x86/intel_pmc_core: Fix the SoC naming inconsistency
> x86/intel_pmc_core: Clean up: Remove comma after the termination line
> x86/intel_pmc_core: Create platform dependent pmc bitmap structs
> x86/intel_pmc_core: Make debugfs entry for pch_ip_power_gating_status
> conditional
> platform/x86: Add Tiger Lake (TGL) platform support to intel_pmc_core
> driver
> platform/x86: Add Atom based Elkhart Lake (EHL) platform support to
> intel_pmc_core driver
> platform/x86: Add Comet Lake (CML) platform support to intel_pmc_core
> driver
>
> drivers/platform/x86/intel_pmc_core.c | 121 ++++++++++++++++++++------
> drivers/platform/x86/intel_pmc_core.h | 2 +-
> 2 files changed, 96 insertions(+), 27 deletions(-)
>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxx>
> Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Cc: Kan Liang <kan.liang@xxxxxxxxx>
> Cc: David E. Box <david.e.box@xxxxxxxxx>
> Cc: Rajneesh Bhardwaj <rajneesh.bhardwaj@xxxxxxxxx>
> Cc: Tony Luck <tony.luck@xxxxxxxxx>
>
> --
> 2.17.1
>


--
With Best Regards,
Andy Shevchenko