RE: [PATCH v2 2/4] scsi: ufs: Update VCCQ2 and VCCQ min/max voltage hard codes

From: Avri Altman
Date: Mon Nov 18 2019 - 02:15:15 EST


>
> From: Can Guo <cang@xxxxxxxxxxxxxx>
>
> Per UFS 3.0 JEDEC standard, the VCCQ2 min voltage is 1.7v and the VCCQ
> voltage range is 1.14v ~ 1.26v. Update their hard codes accordingly to make
> sure they work in a safe range compliant for ver 1.0/2.0/2.1/3.0 UFS devices.
So to keep it safe, we need to use largest range:
min_uV = min over all spec ranges, and max_uV = max over all spec ranges.
Meaning leave it as it is if we want to be backward compatible with UFS1.0.

Thanks,
Avri

>
> Signed-off-by: Can Guo <cang@xxxxxxxxxxxxxx>
> ---
> drivers/scsi/ufs/ufs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h index 385bac8..9df4f4d
> 100644
> --- a/drivers/scsi/ufs/ufs.h
> +++ b/drivers/scsi/ufs/ufs.h
> @@ -500,9 +500,9 @@ struct ufs_query_res {
> #define UFS_VREG_VCC_MAX_UV 3600000 /* uV */
> #define UFS_VREG_VCC_1P8_MIN_UV 1700000 /* uV */
> #define UFS_VREG_VCC_1P8_MAX_UV 1950000 /* uV */
> -#define UFS_VREG_VCCQ_MIN_UV 1100000 /* uV */
> +#define UFS_VREG_VCCQ_MIN_UV 1140000 /* uV */
> #define UFS_VREG_VCCQ_MAX_UV 1300000 /* uV */
> -#define UFS_VREG_VCCQ2_MIN_UV 1650000 /* uV */
> +#define UFS_VREG_VCCQ2_MIN_UV 1700000 /* uV */
> #define UFS_VREG_VCCQ2_MAX_UV 1950000 /* uV */
>
> /*
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project