Re: [PATCH v10 2/2] selftests: add tests for clone3() with *set_tid

From: Andrei Vagin
Date: Fri Nov 15 2019 - 13:39:48 EST


On Fri, Nov 15, 2019 at 7:14 AM Adrian Reber <areber@xxxxxxxxxx> wrote:
>
> On Thu, Nov 14, 2019 at 10:34:21AM -0800, Andrei Vagin wrote:
>
> > > + snprintf(proc_path, sizeof(proc_path), "/proc/%d/status", pid);
> > > + f = fopen(proc_path, "r");
> > > + if (f == NULL)
> > > + ksft_exit_fail_msg(
> > > + "%s - Could not open %s\n",
> > > + strerror(errno), proc_path);
>
> If the child does not exist anymore, the test will fail here and exit.
>
> Besides this while() I tried to address all your comments in v11. Any
> further comments on the test?

No, I don't have any other comments.

Thanks,
Andrei