Re: [PATCH] thunderbolt: Power cycle the router if NVM authentication fails

From: Mika Westerberg
Date: Fri Nov 15 2019 - 06:56:13 EST


On Tue, Nov 12, 2019 at 12:24:52PM +0300, Mika Westerberg wrote:
> On zang's Dell XPS 13 9370 after Thunderbolt NVM firmware upgrade the
> Thunderbolt controller did not come back as expected. Only after the
> system was rebooted it became available again. It is not entirely clear
> what happened but I suspect the new NVM firmware image authentication
> failed for some reason. Regardless of this the router needs to be power
> cycled if NVM authentication fails in order to get it fully functional
> again.
>
> This modifies the driver to issue a power cycle in case the NVM
> authentication fails immediately when dma_port_flash_update_auth()
> returns. We also need to call tb_switch_set_uuid() earlier to be able to
> fetch possible NVM authentication failure when DMA port is added.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=205457
> Reported-by: zang <dump@xxxxxxxx>
> Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> ---
> This applies on top of my thunderbolt.git/next.

Applied to thunderbolt.git/next.