Re: [PATCH RESEND v2 1/4] cpuidle-haltpoll: ensure grow start value is nonzero

From: Rafael J. Wysocki
Date: Fri Nov 15 2019 - 05:16:59 EST


On Fri, Nov 15, 2019 at 11:06 AM Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote:
>
> On Wednesday, November 6, 2019 12:54:59 PM CET Zhenzhong Duan wrote:
> > dev->poll_limit_ns could be zeroed in certain cases (e.g. by
> > guest_halt_poll_ns = 0). If guest_halt_poll_grow_start is zero,
> > dev->poll_limit_ns will never be bigger than zero.
>
> Given that haltpoll_enable_device() sets dev->poll_limit_ns = 0 to start with,
> I don't think that the statement above is correct.

Scratch this, I misread it.