Re: [PATCH] IB/qib: Validate ->show()/store() callbacks before calling them

From: Jason Gunthorpe
Date: Thu Nov 14 2019 - 10:54:18 EST


On Thu, Nov 07, 2019 at 08:50:25AM +0530, Viresh Kumar wrote:
> The permissions of the read-only or write-only sysfs files can be
> changed (as root) and the user can then try to read a write-only file or
> write to a read-only file which will lead to kernel crash here.
>
> Protect against that by always validating the show/store callbacks.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> ---
> drivers/infiniband/hw/qib/qib_sysfs.c | 6 ++++++
> 1 file changed, 6 insertions(+)

Applied to for-next, thanks

Jason