Re: [PATCH BUGFIX V2 0/1] block, bfq: deschedule empty bfq_queues not referred by any process

From: Paolo Valente
Date: Thu Nov 14 2019 - 10:14:21 EST




> Il giorno 14 nov 2019, alle ore 15:02, Jens Axboe <axboe@xxxxxxxxx> ha scritto:
>
> On 11/14/19 2:33 AM, Paolo Valente wrote:
>> Hi Jens,
>> change from V1: added check to correctly work only on bfq-queues
>> scheduled for service, and not on in-service bfq-queues (it makes no
>> sense, and it creates inconsistencies, to deschedule an in-service
>> bfq-queue).
>>
>> Differently from V1, which was still under test when I submitted it,
>> this version has already been tested, by those who reported V1's
>> failures.
>
> I'm a bit miffed that you'd send out a patch for an issue, this late
> in the cycle, and then it not being tested at all. That's not very
> confidence inspiring. I have applied this one, just letting you know
> that that is not acceptable at all.
>

I'm sorry for irritating you. Yet I don't fully get your point. I
have sent this fix now, simply because this bug was found ten days
ago, and I've tried to fix it as soon as possible. I did test my
patch before sending it. As for public testing, how could Oleksandr
or any other user/dev have had a chance to test this patch if I had
not submitted it here?

Thanks,
Paolo

> --
> Jens Axboe
>