[PATCH v2 3/3] perf report: Bail out --mem-mode if mem info is not available

From: Ravi Bangoria
Date: Thu Nov 14 2019 - 08:22:48 EST


If perf.data is recorded without -d, don't allow user to use
--mem-mode with perf report. symbol_daddr and phys_daddr can
be recorded separately and may be present in the perf.data but
at the report time they are associated with mem-mode fields and
thus this restriction applies to them as well.

Before:
$ ./perf record ls
$ ./perf report --mem-mode --stdio
# Overhead Local Weight Memory access Symbol
# ........ ............ ............. .......................
55.56% 0 N/A [k] 0xffffffff81a00ae7

After:
$ ./perf report --mem-mode --stdio
Error:
Selected --mem-mode but no mem data. Did you call perf record without -d?

Suggested-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
Signed-off-by: Ravi Bangoria <ravi.bangoria@xxxxxxxxxxxxx>
---
tools/perf/builtin-report.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index aae0e57c60fb..7c854d35c9ef 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -383,6 +383,14 @@ static int report__setup_sample_type(struct report *rep)
}
}

+ if (sort__mode == SORT_MODE__MEMORY) {
+ if (!is_pipe && !(sample_type & PERF_SAMPLE_DATA_SRC)) {
+ ui__error("Selected --mem-mode but no mem data. "
+ "Did you call perf record without -d?\n");
+ return -1;
+ }
+ }
+
if (symbol_conf.use_callchain || symbol_conf.cumulate_callchain) {
if ((sample_type & PERF_SAMPLE_REGS_USER) &&
(sample_type & PERF_SAMPLE_STACK_USER)) {
--
2.21.0