Re: [PATCH v9 1/2] fork: extend clone3() to support setting a PID

From: Christian Brauner
Date: Thu Nov 14 2019 - 03:14:21 EST


On Thu, Nov 14, 2019 at 08:07:08AM +0100, Adrian Reber wrote:
> * The structure is versioned by size and thus extensible.
> * New struct members must go at the end of the struct and
> @@ -71,6 +85,8 @@ struct clone_args {
> __aligned_u64 stack;
> __aligned_u64 stack_size;
> __aligned_u64 tls;
> + __aligned_u64 set_tid;
> + __aligned_u64 set_tid_size;

Oh, one thing that is missing is the addition of

+#define CLONE_ARGS_SIZE_VER1 80 /* sizeof second published struct */

in sched.h. Please add that, when you resend.

Thanks!
Christian