Re: [PATCH v2] firmware_class: make firmware caching configurable

From: Luis Chamberlain
Date: Wed Nov 13 2019 - 19:26:13 EST


On Wed, Nov 13, 2019 at 04:16:38PM -0800, Mark Salyzyn wrote:
> On 11/13/19 3:16 PM, Luis Chamberlain wrote:
> > On Wed, Nov 13, 2019 at 02:54:26PM -0800, Mark Salyzyn wrote:
> > > +config FW_CACHE
> > > + bool "Enable firmware caching during suspend"
> > > + depends on PM_SLEEP
> > > + default y if PM_SLEEP
> > I think the default y would suffice given you have depends on PM_SLEEP,
> > however this also works. So, again:
> >
> > Acked-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>
> >
> > Luis
>
> Worried about setting FW_CACHE w/o PM_SLEEP, this enforces it.

I understand, but its an impossibility to turn on FW_CACHE without
PM_SLEEP since it depends on it. How would one do that?

However, since it makes no difference we can leave it.

Luis