Re: [PATCH] staging: exfat: Fix CamelCase in function names

From: Greg KH
Date: Wed Nov 13 2019 - 16:47:00 EST


On Wed, Nov 13, 2019 at 12:43:48PM -0500, Javier F. Arias wrote:
> This patch fixes CamelCase in function names with the ffs prefix.
> Issue found by checkpatch.
>
> Signed-off-by: Javier F. Arias <jarias.linux@xxxxxxxxx>
> ---
> drivers/staging/exfat/exfat_super.c | 84 ++++++++++++++---------------
> 1 file changed, 42 insertions(+), 42 deletions(-)
>
> diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
> index 23002aefc964..a6bbf0d7d378 100644
> --- a/drivers/staging/exfat/exfat_super.c
> +++ b/drivers/staging/exfat/exfat_super.c
> @@ -343,7 +343,7 @@ static inline void exfat_save_attr(struct inode *inode, u32 attr)
> EXFAT_I(inode)->fid.attr = attr & (ATTR_RWMASK | ATTR_READONLY);
> }
>
> -static int ffsMountVol(struct super_block *sb)
> +static int ffs_mount_vol(struct super_block *sb)

Can't you just get rid of the crazy ffs prefix as well?

That would be best, look at the TODO file, it says to do just that :)

thanks,

greg k-h