Re: [PATCH 4.19 097/125] perf/x86/uncore: Fix event group support

[Liang, Kan]

On 11/13/2019 5:35 AM, Pavel Machek wrote:
> Hi!
>
> >   	return ret;
> >   }
> >   
> > +static void uncore_pmu_enable(struct pmu *pmu)
> > +{
> > +	struct intel_uncore_pmu *uncore_pmu;
> > +	struct intel_uncore_box *box;
> > +
> > +	uncore_pmu = container_of(pmu, struct intel_uncore_pmu, pmu);
> > +	if (!uncore_pmu)
> > +		return;
>
> AFAICT this test can never trigger.
>
> > +static void uncore_pmu_disable(struct pmu *pmu)
> > +{
> > +	struct intel_uncore_pmu *uncore_pmu;
> > +	struct intel_uncore_box *box;
> > +
> > +	uncore_pmu = container_of(pmu, struct intel_uncore_pmu, pmu);
> > +	if (!uncore_pmu)
> > +		return;
>
> And neither can this one.

I will submit a patch to fix it.

Thanks,
Kan