RE: [PATCH 1/2] clk: imx: pll14xx: use writel_relaxed

From: Peng Fan
Date: Wed Nov 13 2019 - 07:15:51 EST


Hi Daniel,

> Subject: Re: [PATCH 1/2] clk: imx: pll14xx: use writel_relaxed
>
>
> On Wed, 2019-11-13 at 07:24 +0000, Peng Fan wrote:
> > From: Peng Fan <peng.fan@xxxxxxx>
> >
> > It not make sense to use writel, use relaxed variant.
> >
>
> Hi Peng,
>
> Please explain why this change is needed.

writel has a barrier, however that barrier is not needed,
because device memory access is in order and clk driver
has spin_lock or other lock to make sure write finished.

I would hear more comments before I post V2 about
the change and other similar patches to switch to
use relaxed API.

Thanks,
Peng.